-
Notifications
You must be signed in to change notification settings - Fork 0
Add additional NOM metadata to data portal #1719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @naglepuff ! There are two updates I'm hoping we can make? 1 ) I know you asked about displaying all Otherwise this looks great! |
Thanks for the feedback @samobermiller! I'll start working on the changes |
aeb924d
to
1995b4b
Compare
@samobermiller I've addressed your comments and updated the PR description and screenshot to reflect the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny grammar change but otherwise everything looks great. No issues during ingest.
Thank you! These changes look great |
Co-authored-by: Mary Salvi <40494088+marySalvi@users.noreply.github.com>
Fix #1681
Changes
Adds
eluent_introduction_category
,sampled_portion
, andpolarity_mode
to the data object table for Natural Organic Matter workflow outputs.Ingest Changes
Two changes have been made to data generation ingest.
sampled_portion
fromall processed samples in the chaindirect processed sample inputs to Data Generation records and store this in theannotations
column (which is a JSONB column) for each data generation. After ingest you can see the results withSELECT DISTINCT(annotations->>'sampled_portions') FROM omics_processing;
polarity_mode
of the mass spectrometry configuration in a similar manner.Frontend Changes
Logic similar to changes made for lipidomics has been added to the

DataObjectTable
component to render this additional metadata in the appropriate headers.