Handle case where sampled_portions is null/undefined
#1728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes a bug where data object tables fail to open when the data generation's annotations object lacks a sampled_portions key by adding optional chaining to prevent undefined property access.
- Added optional chaining operator (
?.) to safely check forsampled_portionsarray length - Prevents runtime errors when
sampled_portionsis undefined in annotations
eecavanna
approved these changes
Aug 12, 2025
eecavanna
changed the title
sampled_portions is null/undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that prevents data object tables from opening if the corresponding data generation has no
sampled_portionskey in itsannotations.