Skip to content

Resize visualization components #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

Conversation

naglepuff
Copy link
Collaborator

Fix #1524

Changes

This is a simple and straightforward change that adjusts the height and width of the visualizations that appear underneath the map and data type bar chart on the data portal. The addition of new data types caused the upset plot to be difficult to read:
image

Additionally, much of the collection date histogram is effectively whitespace (looking at pre-2014). To remedy the readability of the upset plot, the heights of these components has been increased (they also now match), and each component now takes up an equal amount of horizontal space:
image

Now each bar in the upset plot is given more space.

@naglepuff
Copy link
Collaborator Author

@aclum please let me know if this sufficiently addresses the issue. I can provide additional screenshots if needed.

@codytodonnell please take a look at the changes and let me know if anything seems off to you.

Copy link
Collaborator

@codytodonnell codytodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resized plot looks great to me. and code changes make sense.

I believe I found another upset plot issue (exists in main not just this branch). The issue is with the applied multiomics filters not matching my expectation when I click on a bar from the upset plot. For example, in my data the first bar on the top looks to be associated with "MP" but when I click that bar, the applied filter is "MT." There are several mismatches like this when I click through the bars.

@codytodonnell
Copy link
Collaborator

Nevermind the above, it looks like this is fixed by #1740

@naglepuff naglepuff merged commit db85929 into main Aug 19, 2025
2 checks passed
@naglepuff naglepuff deleted the issue-1524-squished-upset-plot branch August 19, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upset plot is looking squished
2 participants