Upgrade: Artifact actions from deprecated v3 to v4

[frank-64]

Motivation and Context

This pipeline is failing due to the now deprecated version of the artifact actions used within sample-app-github-cd.yml

https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

I think this is causing other deployments from the Azure Portal to now fail:

My fix attempts to solve this issue.

Description

I updated the .yml of the GitHub action workflow to use the new v4 actions instead of the deprecated v3 actions for:
Upload artifact for deployment jobs:
actions/upload-artifact@v3 -> actions/upload-artifact@v4

Download artifact from build job:
actions/download-artifact@v3 -> actions/download-artifact@v4

Testing

I ran the pipeline in my fork to test that it would run.
The build and deploy now succeed.

Contribution Checklist

• I have built and tested the code locally and in a deployed app
• For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files. N/A
• This is a change for all users of this app. No code or asset is specific to my use case or my organization.
• I didn't break any existing functionality 😄

[frank-64]

Causing issues for other users trying to deploy from the playground: https://learn.microsoft.com/en-us/answers/questions/2182975/open-ai-web-app-failed-to-deploy

Please, could this be reviewed? @sarah-widder

[sarah-widder]

Thanks for this fix @frank-64 ! I don't think this will help with issues when deploying from the Foundry portal, since this pipeline is actually not involved in that process. Deployment issues from Foundry are usually due to a known issue with App Services pulling from the External Git connection to this repo, and they are usually solved by manually triggering a fresh 'Sync' from the app Deployment Center.