Skip to content

Better Russian language #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

SkyBuilder1717
Copy link

@SkyBuilder1717 SkyBuilder1717 commented Feb 12, 2025

Current Russian was too offset from original strings, but I am here to fix it!

Fixed several Russian translations files, also deleted several useless strings.

Commits is bit of a mess, but trust me!

@SmallJoker
Copy link
Member

Reviews are welcome. I skimmed through the strings and they seem OK.
@randomei Might you be interested in having a look at it? (ping due to #692)

@SmallJoker
Copy link
Member

SmallJoker commented Mar 5, 2025

LGTM. Will merge in a few days unless there are objections.

@randomei
Copy link
Contributor

randomei commented Mar 6, 2025

I'm objecting, because naming change is not close to original: 'lexiCON', 'heliCONs' - translating to 'лексиКОН', 'гелиКОНы'. Why should Mesecons be renamed differently?

@SkyBuilder1717
Copy link
Author

SkyBuilder1717 commented Mar 7, 2025

I'm objecting, because naming change is not close to original: 'lexiCON', 'heliCONs' - translating to 'лексиКОН', 'гелиКОНы'. Why should Mesecons be renamed differently?

Melectronic sounds more logical rather than Mezecons.
Mesecons about wires and machinery, so name Melectronic sounds good in opinion.

@SmallJoker
Copy link
Member

"mesecons" has no direct meaning in English. It contains "cons", a short form for "connections", but that's about it.
"mesecons" is a name. For example, I won't think you would translate "Amazon" into "Gigantic River" - or "Greenland" into "Northern Ice Plains". I would like to have a translation that resembles the English variant in pronunciation in this case. Hence, "Mezecons".

@randomei
Copy link
Contributor

randomei commented Mar 7, 2025

@SmallJoker also this pr is removing easter egg at mesecons_delayer/init.lua 109, what do you think about this?

@SmallJoker
Copy link
Member

Apparently I did not pay attention at all while browsing through the diff of this PR.
I personally like that easter egg. It's only one string and doesn't need a translation if that's a concern. Please revert the Lua code changes for now. Let's limit this PR to translations only.

@SkyBuilder1717
Copy link
Author

Apparently I did not pay attention at all while browsing through the diff of this PR. I personally like that easter egg. It's only one string and doesn't need a translation if that's a concern. Please revert the Lua code changes for now. Let's limit this PR to translations only.

Done

@randomei
Copy link
Contributor

randomei commented Mar 8, 2025

@SkyBuilder1717 But still, the mod name and its derivatives were changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants