Skip to content

feat: add bordered variant for buttons #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ChristopherChudzicki
Copy link
Collaborator

What are the relevant tickets?

For https://github.com/mitodl/hq/issues/6279

Description (What does it do?)

Adds the "bordered" button variant, introduced in MIT Learn in mitodl/mit-learn#1900

How can this be tested?

With the repo set up (just yarn install)

  1. Run yarn start to start storybook.
  2. View the new bordered button variant
  3. ☝️ should look the same as the "bordered" variant at https://mitodl.github.io/mit-learn/?path=/story/smoot-design-button--variant-story

@jkachel jkachel self-assigned this Dec 20, 2024
@jkachel jkachel self-requested a review December 20, 2024 13:26
Copy link
Contributor

@jkachel jkachel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ChristopherChudzicki ChristopherChudzicki merged commit d04887c into main Dec 20, 2024
7 checks passed
@ChristopherChudzicki
Copy link
Collaborator Author

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants