-
Notifications
You must be signed in to change notification settings - Fork 0
chore: Add release action #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d06e51e
to
cd7a8f8
Compare
cd7a8f8
to
12d0192
Compare
12d0192
to
de0cded
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing
.github/workflows/release.yml
Outdated
env: | ||
GITHUB_TOKEN: ${{ secrets.SEMANTIC_RELEASE_GITHUB_TOKEN }} | ||
NPM_TOKEN: ${{ secrets.SEMANTIC_RELEASE_NPM_TOKEN }} | ||
run: npx semantic-release --dry-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this still have --dry-run
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Removed that, and removed cc/releasing
from the releaserc branches section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What are the relevant tickets?
For https://github.com/mitodl/hq/issues/6039
Description (What does it do?)
This PR adds semantic-release to release this package. It:
How can this be tested?
gh workflow run release --ref cc/releasing
. Once this PR is merged, it can be manually triggered via action button.Checklist:
cc/releasing
from.releaserc