fix: export module augmentation for consuming applications #8
+28
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
changed the title
| @@ -16,7 +16,8 @@ | |||
| "typecheck": "tsc --noEmit", | |||
| "build:esm": "tsc", | |||
| "build:cjs": "tsc --module commonjs --outDir dist/cjs", | |||
| "build": "rm -rf dist && rm -f .tsbuildinfo && npm run build:esm && npm run build:cjs", | |||
| "build:type-augmentation": "cp -r src/type-augmentation dist/type-augmentation", | |||
There was a problem hiding this comment.
This exists because Typescript does not by default include any source .d.ts files in the output.
Potentially these could just be .ts files, in whcih case they would be included. But keeping them as .d.ts 100% ensures they have no runtime impact.
ChristopherChudzicki
force-pushed
the
cc/fix-types
branch
from
a13919c to
c8c4cf4
Compare
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (What does it do?)
Enables smoot-design's module augmentation to work in consuming applications.
How can this be tested?
yarn installandyarn storybook, read http://localhost:6006/?path=/docs/smoot-design-themeprovider--docscc/setup, and observe that inHeader.tsx, thetheme.customprops come through.