chore(e2e-tests): wait for data modeling components in tests #7215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
added
the
no-title-validation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses test flakiness in the data modeling tab end-to-end tests by replacing brittle synchronous assertions with more robust asynchronous waiting patterns.
- Replaces
isDisplayed()andisExisting()assertions withwaitForDisplayed()calls - Adds explicit waits for relationship edit buttons before attempting to interact with them
- Uses
waitForDisplayed({ reverse: true })to wait for element removal instead of checking existence
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lerouxb
reviewed
Aug 19, 2025
| @@ -585,11 +585,13 @@ describe('Data Modeling tab', function () { | |||
| const relationshipItem = drawer.$( | |||
| Selectors.DataModelCollectionRelationshipItem(relationshipId) | |||
| ); | |||
| expect(await relationshipItem.isDisplayed()).to.be.true; | |||
| await relationshipItem.waitForDisplayed(); | |||
lerouxb
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the following flakes:
https://parsley.mongodb.com/test/10gen_compass_main_test_packaged_app_macos_14_x64_test_packaged_app_2_3883a58f02d467a07462a326fe2559b0cb672010_25_08_19_16_08_15/0/a8352028097e38aa69aa7787580e602d?bookmarks=0,8&shareLine=0
https://parsley.mongodb.com/test/10gen_compass_main_test_packaged_app_rhel_test_packaged_app_2_37f34fac1b921225b14697730c0564ab569113ad_25_08_18_19_43_43/0/f595bc23473e1bb5ae834dd14010291d?bookmarks=0,14&shareLine=0