Skip to content

chore(shell-api): add test and type updates for sort #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gagik
Copy link
Contributor

@gagik gagik commented Aug 20, 2025

Followed up from the driver update, tests to ensure the new sort option works.

@Copilot Copilot AI review requested due to automatic review settings August 20, 2025 11:20
@gagik gagik requested a review from a team as a code owner August 20, 2025 11:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds test coverage and type updates for the sort option in MongoDB's updateOne and replaceOne operations. The changes ensure that the shell API properly supports sorting to determine which document gets updated when multiple documents match the filter criteria.

  • Adds comprehensive integration tests for updateOne and replaceOne with sort options
  • Updates TypeScript type definitions to include the sort parameter
  • Updates JSDoc comments to document the new sort option

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/shell-api/src/integration.spec.ts Adds test cases verifying sort functionality for updateOne and replaceOne operations
packages/shell-api/src/collection.ts Updates type signature and documentation for updateOne method to include sort option
packages/service-provider-core/src/writable.ts Updates interface type definition to include sort option in updateOne method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gagik gagik added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Aug 20, 2025
@gagik gagik changed the title chore(shell-api): add test and type updates for sort chore(shell-api): add test and type updates for sort CLOUDP-336196 Aug 20, 2025
@gagik gagik changed the title chore(shell-api): add test and type updates for sort CLOUDP-336196 chore(shell-api): add test and type updates for sort Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant