[Moodle 5.0] Remove deprecated report builder default table alias #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneno-m-e
force-pushed
the
MOODLE_400_STABLE
branch
from
5558c0d to
be3333c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installed on Moodle 5.0, unit tests fail on
Fatal error: Declaration of tool_certificate\reportbuilder\local\entities\issue::get_default_table_aliases(): array must be compatible with core_reportbuilder\local\entities\base::get_default_table_aliases(): voidIt is a consequence of this change. I've updated the plugin code to align it with the updated Moodle code.