add explicit trait implementation #62
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes waning 0045. In the future, a trait where all methods have default implementation can no longer be implemented explicitly. A
impl Trait for Type
declaration must be declared. In the case of@quickcheck
, all methods of traitShrink
has default implementation.While fixing, a subtle bug is found. Due to the coherence issue in moonbitlang/moonbit-docs#819, many implementations of
Shrink
are notpub
, but this is never discovered. In some cases (directly applyShrink::shrink
on a known type) this can lead to unexpected behavior.Some builtin types, such as
Double
andString
, are missing aShrink
implementation. This can lead to warnings for downstream users, so I added empty placeholderimpl
declaration for them.