Skip to content

External Display Support #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SilenTree12th
Copy link

So I made this feature request yesterday and I figured "wth, I'll just do it myself."

TL:DR:

After figuring out that Samsung DeX can in fact use higher resolutions (thanks to the Good Lock app and its plugin MultiStar) I realized that within Samsung DeX the Moonlight settings show neither the external monitor's resolution and framerate capabilities nor the ones of the phone. That has now changed.

What I did:

  • Changed one line of code to not just find the default phone display but to find all available displays and made the "native settings section" (lines 354 - 613) loop through all available displays.
  • Added the import of DisplayManager (line 29)
  • I let Android Studio change some dependencies to newer version.
  • Tested the changes on a Samsung Note 20 Ultra 5G within and outside Samsung DeX

What I did not do:

  • Test on other phones and/or Android versions.

I really hope this will get pulled soon and we can see the new version of Moonlight in the app stores.

@alxtraxxx
Copy link

Do you initialize screen mode in another way than original does? Will this work with android TVs too?
I am asking because FireTV stick and moonlight running native on my android tv wont output more than PCM Stereo on newer devices, while old TVs\AVRs with lower HDCP and HDMI version seem to work. I am still hoping someone fixes it by setting some other flag X) I tried myself but failed as I have no idea of android coding.
I am using the steam streaming speaker and they work correctly when using steam link so it is related to moonlight :(

@SilenTree12th
Copy link
Author

Do you initialize screen mode in another way than original does? Will this work with android TVs too? I am asking because FireTV stick and moonlight running native on my android tv wont output more than PCM Stereo on newer devices, while old TVs\AVRs with lower HDCP and HDMI version seem to work. I am still hoping someone fixes it by setting some other flag X) I tried myself but failed as I have no idea of android coding. I am using the steam streaming speaker and they work correctly when using steam link so it is related to moonlight :(

Hi,
No, the only change is to recognize external displays. Everything else I haven't touched.

@alxtraxxx
Copy link

Too bad, I hoped there would be a solution, seems not many devs here care about the surround bug :( But thanks for answering so quick.😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants