Add runtime context parameter for callbacks #760
+18
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My take on the discussion in #607
The issue raised a good point about callbacks needing access to runtime objects like A2A task updaters. I took a shot at implementing this with what seemed like the most straightforward approach.
What I built
Added a
runtime_context
parameter to run methods that gets passed through to callbacks:Callbacks can then grab what they need:
Implementation approach
runtime_context
field to the existing Context objectWhy this approach
Seemed like the cleanest way to solve the A2A task updater problem without over-engineering it. The Context object already flows through all callbacks, so extending it felt natural.
Happy to adjust based on feedback!
Addresses #607