Chore: Some required clean up (#40)

* Remove DEBUG log lines that leak req/resp data
* Docsgen logger should use stderr (visible in CI)
* Update GH action for docs to trigger for changes to our tools/docsgen files
* Log line added for starting the health check

Author: peteski22

.github/workflows/deploy-docs.yaml

@@ -6,6 +6,7 @@ on:
     paths:
       - "cmd/**"
       - "docs/**"
+      - "tools/docsgen/**"
   workflow_dispatch:
 
 permissions:

internal/daemon/daemon.go

@@ -177,7 +177,6 @@ func (d *Daemon) launchServer(ctx context.Context, server runtime.Server, wg *sy
 		"environment", env,
 	)
 	fmt.Println(fmt.Sprintf("Starting MCP server: '%s'...", server.Name))
-
 	stdioClient, err := client.NewStdioMCPClient(runtimeBinary, env, args...)
 	if err != nil {
 		return fmt.Errorf("error starting MCP server: '%s': %w", server.Name, err)
@@ -292,6 +291,8 @@ func (d *Daemon) healthCheckLoop(
 	interval time.Duration,
 	timeout time.Duration,
 ) {
+	d.logger.Info("Starting health check loop", "interval", interval, "timeout", timeout)
+
 	ticker := time.NewTicker(interval)
 	defer ticker.Stop()
 

internal/daemon/server.go

@@ -129,8 +129,6 @@ func (a *ApiServer) handleApiRequest(w http.ResponseWriter, r *http.Request) {
 		if err != nil {
 			a.handleError(w, err)
 		} else {
-			// TODO: Remove debug logging for this later to prevent data leaking into logs.
-			a.logger.Debug("API request response", "method", r.Method, "path", path, "result", result)
 			a.writeJSON(w, result)
 		}
 	}
@@ -215,9 +213,6 @@ func (a *ApiServer) callTool(ctx context.Context, serverName, toolName string, a
 		return nil, fmt.Errorf("%w: %s/%s", ErrToolForbidden, serverName, toolName)
 	}
 
-	// TODO: Remove debug logging later to prevent data leaking into logs.
-	a.logger.Debug("Calling tool", "server", serverName, "tool", toolName, "args", args)
-
 	result, err := mcpClient.CallTool(ctx, mcp.CallToolRequest{
 		Params: mcp.CallToolParams{
 			Name:      toolName,

tools/docsgen/cli/cmds.go

@@ -4,7 +4,6 @@
 package main
 
 import (
-	"io"
 	"os"
 
 	"github.com/hashicorp/go-hclog"
@@ -19,7 +18,7 @@ func main() {
 	logger := hclog.New(&hclog.LoggerOptions{
 		Name:   "mcpd.docsgen",
 		Level:  hclog.Info,
-		Output: io.Discard, // TODO: need to be able to configure this for log file/stdout/stderr.
+		Output: os.Stderr,
 	})
 
 	// docsPath is the path to the commands documentation, relative to the repository root.