Bug fixes for arg parsing and support for positional arguments #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteski22
force-pushed
the
peteski22/transports/update-package-bugfix-mcpm
branch
from
0f6df63 to
6bf6a71
Compare
peteski22
changed the title
peteski22
force-pushed
the
peteski22/transports/update-package-bugfix-mcpm
branch
from
6bf6a71 to
334de86
Compare
* Bug Fix - Missing Required Args * Bug Fix - Neo4j Duplicate Arguments * Test Case Corrections * Added Positional Arguments Support (in CLI config set args too) * Terminal text output update for results
peteski22
force-pushed
the
peteski22/transports/update-package-bugfix-mcpm
branch
from
334de86 to
97636c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes Made
Bug in MCPM registry where some required arguments were being missed/not extracted properly.
mcp-neo4j-memoryserver was extracting 6 arguments instead of 3 (duplicate processing).Some test cases had incorrect expectations - expecting positional placeholders as environment variables.
VariableTypePositionalArgconstant and full positional argument supportArgumentMetadatawithPosition*int field andNamefieldOrdered()method for proper argument ordering (positional first, then others alphabetically)Positional arguments were incorrectly displayed as "command line flags", added new dedicated section with logical numbering.
mcpd config args setcan now handle positional arguments.