Changes to play count custom text behaviour #29232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! |
avvvvve
approved these changes
Aug 13, 2025
its-not-nice
approved these changes
Aug 14, 2025
This comment was marked as outdated.
This comment was marked as outdated.
|
@abariska thanks for testing! I think it would be good to fix the second item, "The text element is not focused after being unhidden" in this PR if it's a quick job. @miiizen if the other two things are really quick 5-min fixes, feel free to address them here, otherwise I'd say they should not hold up merging this. |
mike-spa
approved these changes
Aug 18, 2025
miiizen
force-pushed
the
29227-playcount-fix
branch
from
4851ea9 to
9723264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #29227
This addresses the issues identified in this comment: #29227 (comment)
In the case of the styles menu being opened during text editing and the preset changed, upon ending editing the play count text auto/custom/off setting will be changed to custom.