Chord symbol parentheses improvements #29275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its-not-nice
approved these changes
Aug 15, 2025
mike-spa
reviewed
Aug 18, 2025
| ldata->midPointThickness.set_value(ldata->height / 60 * ldata->mag()); // 0.1sp for a height of 6sp | ||
| ldata->startY = top; | ||
| ldata->height = height; | ||
| ldata->midPointThickness.set_value(ldata->height / 20 * ldata->mag() * std::pow(scale, -0.5)); |
There was a problem hiding this comment.
I know that the rationale behind these formulas is simply "what makes them look good". But, forgive my nitpicking
- let's make a constexpr for that 20, something like HEIGHT_TO_WIDTH_RATIO
- writing
scaleto the power of -0.5 is the same as writing1/sqrt(scale), which looks a lot less arcane
| ldata->midPointThickness.set_value(ldata->height / 20 * ldata->mag() * std::pow(scale, -0.5)); | ||
| ldata->endPointThickness.set_value(endPointThickness); | ||
|
|
||
| double shoulder = 0.2 * std::pow(ldata->height, 0.99) * std::pow(ldata->mag(), 0.1) * std::pow(scale, -0.5); |
There was a problem hiding this comment.
- Same comment about the power of -0.5
- Joke goes that for an engineer pi and 3 are the same number, which means for me
heightto the power of 0.99 is literally the same thing asheight🤣. Silliness aside, that looks very weird and I'd be surprised if it makes an even vtest-detectable difference
mike-spa
approved these changes
Aug 19, 2025
miiizen
pushed a commit
to miiizen/MuseScore
that referenced
this pull request
Aug 19, 2025
Chord symbol parentheses improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #29250
This PR includes parentheses in the chord symbol shape for horizontal spacing and improvements to parenthesis placement and shape.