Change when text style popup appears #29284
Merged
+63
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
force-pushed
the
textstylepopup/when
branch
from
ebab7e0 to
98c559b
Compare
…er palette element
When a `hide` was immediately followed by a `show` in the same event loop tick, the `show` would have no effect, since `m_currentElementPopupType` would not reflect the fact that `hide` had been called until the next event loop tick.
cbjeukendrup
force-pushed
the
textstylepopup/when
branch
from
98c559b to
a6d253c
Compare
4 tasks
|
I've just tried this out @cbjeukendrup and I'm loving the new interaction behaviour. Would it be possible to add a fix for this issue in this PR too? (Or would you prefer to handle it separately)? |
|
That issue is a lot trickier and should preferably be handled separately (possibly by someone else than me, but I'll discuss it on Slack) |
RomanPudashkin
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #29241
Resolves: #29319