Fix #28379: Hairpin not being selected by opt+Left #29285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
approved these changes
Aug 15, 2025
mathesoncalum
force-pushed
the
28379-hairpin_prev_element
branch
from
ca01116 to
0e041d2
Compare
cbjeukendrup
approved these changes
Aug 21, 2025
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #28379
There are a few ways to approach this (e.g. we could use
Dynamic::leftHairpin) but the solution I've gone for here is to mirror some missing logic that we already have inSegment:nextElement.This issue highlights a problem we have with
nextElement/prevElement. It certainly feels like there's a solution out there that prevents the need for this mirroring/duplication (probably quite a big/risky undertaking though).