moveElementSelection: only start editing when selected element wants it #29287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| m_editData.element->startEdit(m_editData); | ||
| if (grip == engraving::Grip::NO_GRIP && m_editData.element->isDynamic()) { | ||
| // Ensure we don't start text edit mode. See also Dynamic::startEdit. | ||
| m_editData.element->EngravingItem::startEdit(m_editData); |
There was a problem hiding this comment.
What do you think about adding a bool flag to EditData that will indicate whether we should start the text edit mode or not?
There was a problem hiding this comment.
Pushed a completely different fix, following advice from Michele on Slack.
Since musescore@b5dc600, it would cause text editing to be started, since `Dynamic::defaultGrip` (==`EngravingItem::defaultGrip`) (intentionally) returns NO_GRIP. Resolves: musescore#29286
This reverts commit fb1fca1. That commit was not a correct fix. Since `NotationInteraction::drawGripPoints` already contains a special case for dynamics, we should not call any sort of `startEditElement` method at all when selecting a dynamic, respecting Dynamic::needStartEditingAfterSelecting.
- Check toEl->needStartEditingAfterSelecting() - Use `startEditElement` rather than `startEditGrip` - Improve `startEditElement` to be appropriate for all elements
cbjeukendrup
force-pushed
the
dynamic_starteditgrip
branch
from
c3ad921 to
26bdd2a
Compare
cbjeukendrup
changed the title
NotationInteraction::startEditGrip for dynamics
mike-spa
approved these changes
Aug 19, 2025
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved #29286 FIXED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since b5dc600, it would cause text editing to be started, since
Dynamic::defaultGrip(==EngravingItem::defaultGrip) (intentionally) returns NO_GRIP.Resolves: #29286
(The change in
NotationInteraction::startEditGripis not great, but I don't see a better way at the moment)