4.6 ports #29317
Merged
4.6 ports #29317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was calling `TDraw::draw(const Tapping* item, …)` on a `Tapping` with neither a symbol nor Text but only a TappingHalfSlur. In that case, the half slur is drawn via `TDraw::draw(const SlurSegment* item, …)`, and the `Tapping` itself is not drawn at all because its bbox is empty, and elements with empty bbox are normally filtered out for drawing by `BspTree::items`, which checks for `bbox` intersection with the viewport rect, and empty RectF never intersects. Added a similar bbox check in SVG export, and added a super light safety check in TDraw as well. Resolves: musescore#29257
RomanPudashkin
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports: #29280
Ports: #29295