Skip to content

Refine online sounds error dialog #29330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RomanPudashkin
Copy link
Contributor

No description provided.

@bkunda
Copy link

bkunda commented Aug 20, 2025

Sorry @RomanPudashkin, I left out a sentence that I think is actually important in the UX flow (since playback does actually initiate despite clicking the OK button). The actual body copy should be:

This may be due to a poor internet connection or server issue. Your score will still play, but some sounds may be missing. Please check your connection or learn more here.

Screenshot 2025-08-20 at 11 29 04 am

@bkunda bkunda added this to the MuseScore 4.6 beta milestone Aug 20, 2025
@bkunda
Copy link

bkunda commented Aug 20, 2025

In addition, we'll need to add a preferences option for this (when the user clicks "Don't show again").

This checkbox will be checked by default. When the user unchecks "Don't show again" in the error dialog, this new checkbox will also become unchecked in Preferences.

Checkbox text label: Show error dialog when online sounds cannot be processed

Screenshot 2025-08-20 at 12 07 15 pm

@RomanPudashkin RomanPudashkin force-pushed the online_sounds_error_dialog branch from 543088c to cba9f6b Compare August 20, 2025 14:56
@RomanPudashkin RomanPudashkin force-pushed the online_sounds_error_dialog branch from cba9f6b to 9ea5c1a Compare August 20, 2025 16:02
@bkunda
Copy link

bkunda commented Aug 21, 2025

🟢 Tested on macOS. Approved.

@RomanPudashkin RomanPudashkin merged commit 9cd1d7a into musescore:master Aug 21, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Needs porting in MuseScore Studio 4.6 Aug 21, 2025
@RomanPudashkin RomanPudashkin deleted the online_sounds_error_dialog branch August 21, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs porting
Development

Successfully merging this pull request may close these issues.

3 participants