Fix out of date padding table for parts #29353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't make sense that it's a member data. Doesn't make sense that it's set by the score constructor.
its-not-nice
approved these changes
Aug 19, 2025
mike-spa
changed the title
miiizen
approved these changes
Aug 19, 2025
mike-spa
pushed a commit
to mike-spa/MuseScore
that referenced
this pull request
Aug 20, 2025
…ableForParts Fix out of date padding table for parts
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26240
We were missing a
createPaddingTablecall for parts. The result was that the last time the padding table was updated for the part was before the style was loaded (hence it was out of date on first opening the file, but was updating itself when a style change was triggered). We probably never noticed because it's more rare for parts to have non-default spatium and non-default spacing settings. Good thing we fixed this.Bonus cleanup while I was at it for the minimum padding unit inside the padding table class (which made no sense to be a class member and especially to be set in the score constructor).