Skip to content

Fretboard diagram legend improvements #29360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2025

Conversation

mike-spa
Copy link
Contributor

@mike-spa mike-spa commented Aug 19, 2025

Resolves: #29351

  • Fixing an error in the height of the box which I had introduced here
  • Removing an unnecessary layout call for chord symbols
  • Fine correction to the shape of fret diagrams (was missing a half line width from the bottom). This is the cause of almost all the vtest differences btw.
  • Improved/simplified calculations of chord symbols vertical positions and alignment (the combination of which was causing them to overshoot the top of the frame). This also makes sure that the 3sp row gap is honored correctly.

@its-not-nice its-not-nice added the vtests This PR produces approved changes to vtest results label Aug 20, 2025
@its-not-nice its-not-nice requested a review from miiizen August 20, 2025 05:27
@miiizen miiizen merged commit 64e2301 into musescore:master Aug 20, 2025
12 of 13 checks passed
mike-spa pushed a commit to mike-spa/MuseScore that referenced this pull request Aug 20, 2025
@mike-spa mike-spa mentioned this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve FDL sizing behaviour
4 participants