Fix rounded corners in popups and dropdowns #29389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great on MacOS :) |
RomanPudashkin
approved these changes
Aug 21, 2025
|
@zacjansheski This affects places where we use images with rounded corners: the avatar in the 'Save to cloud' dialog, images in the 'How would you like to save?' dialog and the welcome dialog. And also the rounded corners or popups and floating dock widgets. |
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #29291
Introduces a new
RoundedCornersEffectshader effect, replacing the masking functionality from Qt5Compat. Using this to clip the contents of popups and dropdowns according to rounded corners.The shader is for a big part written by GitHub Copilot, but I did compare it to solutions found online. I assume that writing a simple shader should be faster than creating another Rectangle and using masking, but I'm not certain of that.