Skip to content

[4.6.0] Change "Respell pitches" to "Optimize enharmonic spelling" and add the "Change enharmonic spelling" commands to the Tools menu #29394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2025
+10 −8
Merged

[4.6.0] Change "Respell pitches" to "Optimize enharmonic spelling" and add the "Change enharmonic spelling" commands to the Tools menu #29394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c8e893
Change "Respell pitches" to "Optimize enharmonic spelling"
Jojo-Schmitz Jan 17, 2025
75544ed
Penality for note spelling is incorrect for Ab (4 flats)
Jojo-Schmitz Jan 20, 2025
e2e79cc
Add enharmonic spelling commands to the Tools menu
Jojo-Schmitz Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/appshell/view/appmenumodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,8 @@ MenuItem* AppMenuModel::makeToolsMenu()
makeMenuItem("slash-fill"),
makeMenuItem("slash-rhythm"),
makeSeparator(),
makeMenuItem("enh-both"),
makeMenuItem("enh-current"),
makeMenuItem("pitch-spell"),
makeMenuItem("reset-groupings"),
makeMenuItem("resequence-rehearsal-marks"),
Expand Down
2 changes: 1 addition & 1 deletion src/engraving/dom/pitchspelling.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ static const int enharmonicSpelling[15][34] = {
//As f c g d a e b
1, 1, 1, 1, 1, 1, // bb
1, 1, 0, 0, 0, 0, 0, // b
0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 1, 1, 1, 1,
0, 1, 1, 1, 1, 1, 1, // #
1, 1, 1, 1, 1, 1, 1 // ##
},
Expand Down
2 changes: 1 addition & 1 deletion src/notation/internal/notationinteraction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6309,7 +6309,7 @@ void NotationInteraction::changeEnharmonicSpelling(bool both)

void NotationInteraction::spellPitches()
{
startEdit(TranslatableString("undoableAction", "Respell pitches"));
startEdit(TranslatableString("undoableAction", "Optimize enharmonic spelling"));
score()->spell();
apply();
}
Expand Down
12 changes: 6 additions & 6 deletions src/notation/internal/notationuiactions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,8 +472,8 @@ const UiActionList NotationUiActions::m_actions = {
UiAction("pitch-spell",
mu::context::UiCtxProjectOpened,
mu::context::CTX_NOTATION_OPENED,
TranslatableString("action", "Respell &pitches"),
TranslatableString("action", "Respell pitches")
TranslatableString("action", "&Optimize enharmonic spelling"),
TranslatableString("action", "Optimize enharmonic spelling")
),
UiAction("reset-groupings",
mu::context::UiCtxProjectOpened,
Expand Down Expand Up @@ -1650,15 +1650,15 @@ const UiActionList NotationUiActions::m_actions = {
UiAction("enh-both",
mu::context::UiCtxProjectOpened,
mu::context::CTX_NOTATION_OPENED,
TranslatableString("action", "Change enharmonic spelling (both modes)"),
TranslatableString("action", "Change enharmonic spelling (concert and written pitch)"),
TranslatableString("action", "Change enharmonic spelling (concert and transposed &pitch)"),
TranslatableString("action", "Change enharmonic spelling (concert and transposed pitch)"),
IconCode::Code::NONE
),
UiAction("enh-current",
mu::context::UiCtxProjectOpened,
mu::context::CTX_NOTATION_OPENED,
TranslatableString("action", "Change enharmonic spelling (current mode)"),
TranslatableString("action", "Change enharmonic spelling (current mode only)"),
TranslatableString("action", "Change enharmonic spelling (&current pitch mode only)"),
TranslatableString("action", "Change enharmonic spelling (current pitch mode only)"),
IconCode::Code::NONE
),
UiAction("flip",
Expand Down
Loading