Pin pytest-qt for python 3.10 to fix pyapp-kit projects tests
#8205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psobolewskiPhD
approved these changes
Aug 12, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8205 +/- ##
==========================================
+ Coverage 92.96% 93.03% +0.07%
==========================================
Files 658 658
Lines 62604 62604
==========================================
+ Hits 58201 58245 +44
+ Misses 4403 4359 -44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
pyapp-kit/app-model#258 (comment)
followup #8067
Description
The
pytest-qtin version 4.5.0 dropped the support for PySide2. In #8067 I've fixed it on our side, but tests of critical for us pyapp-kit projects are broken. This PR fixes their test that uses https://github.com/pyapp-kit/workflows/blob/main/.github/workflows/test-dependents.yml