Skip to content

292 tm process aos process oob read and sa not operational #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Donnie-Ice
Copy link
Collaborator

No description provided.

@Donnie-Ice Donnie-Ice self-assigned this Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 91.91919% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.59%. Comparing base (5dadca4) to head (17e9ed1).
Report is 58 commits behind head on dev.

Files with missing lines Patch % Lines
src/sa/internal/sa_interface_inmemory.template.c 77.14% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #306      +/-   ##
==========================================
+ Coverage   83.51%   83.59%   +0.07%     
==========================================
  Files          39       39              
  Lines       11074    11137      +63     
  Branches      835      838       +3     
==========================================
+ Hits         9249     9310      +61     
- Misses       1518     1519       +1     
- Partials      307      308       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjbrown2
Copy link
Member

I think this is good. Can we clean up a couple of the comments I made? Mainly the DEBUG prints.

@Donnie-Ice Donnie-Ice merged commit f0ee201 into dev Sep 13, 2024
9 checks passed
@Donnie-Ice Donnie-Ice deleted the 292-tm_process-aos_process-oob-read-and-sa_not_operational branch September 13, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants