316 cryptoc cleanup

[Donnie-Ice]

No description provided.

[Donnie-Ice]

Leaving 3 todo's in the code for EP work

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 90.93851% with 28 lines in your changes missing coverage. Please review.

Project coverage is 83.76%. Comparing base (3816e24) to head (17d6806).
Report is 41 commits behind head on dev.

Files with missing lines	Patch %	Lines
src/core/crypto.c	90.93%	14 Missing and 14 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #328      +/-   ##
==========================================
+ Coverage   83.59%   83.76%   +0.16%     
==========================================
  Files          39       79      +40     
  Lines       11138    22032   +10894     
  Branches      842     1660     +818     
==========================================
+ Hits         9311    18455    +9144     
- Misses       1516     2962    +1446     
- Partials      311      615     +304     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Donnie-Ice]

Need to discuss max IV length as a group. Could cause buffer overflows if not handled dynamically.
Edit: Found a commit from last year that attempted to handle this [nasa/nos3#133]

[dccutrig]

Looks good on a scan