Skip to content

310 clean up commented code #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 20, 2025
Merged

310 clean up commented code #419

merged 10 commits into from
Mar 20, 2025

Conversation

Donnie-Ice
Copy link
Collaborator

@Donnie-Ice Donnie-Ice commented Mar 14, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

How do you test these changes?

Removed commented code, test/core files, and test/performance files
Closes #310

@Donnie-Ice Donnie-Ice self-assigned this Mar 14, 2025
@Donnie-Ice Donnie-Ice linked an issue Mar 14, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.60%. Comparing base (14ee573) to head (879dfba).
Report is 68 commits behind head on dev.

Files with missing lines Patch % Lines
src/sa/internal/sa_interface_inmemory.template.c 25.00% 3 Missing ⚠️
src/core/crypto.c 87.50% 0 Missing and 1 partial ⚠️
src/core/crypto_user.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #419      +/-   ##
==========================================
- Coverage   75.97%   75.60%   -0.38%     
==========================================
  Files          81       81              
  Lines       22263    22264       +1     
  Branches     1807     1822      +15     
==========================================
- Hits        16914    16832      -82     
- Misses       4707     4779      +72     
- Partials      642      653      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Donnie-Ice
Copy link
Collaborator Author

Didn't touch test/unit or test/kmc as we may still use those

Copy link
Contributor

@dccutrig dccutrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with Donovan any concerns I had, looks good to go.

@Donnie-Ice Donnie-Ice merged commit 9912149 into dev Mar 20, 2025
12 checks passed
@Donnie-Ice Donnie-Ice deleted the 310-clean-up-commented-code branch March 20, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up Commented Code
4 participants