-
Notifications
You must be signed in to change notification settings - Fork 41
310 clean up commented code #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #419 +/- ##
==========================================
- Coverage 75.97% 75.60% -0.38%
==========================================
Files 81 81
Lines 22263 22264 +1
Branches 1807 1822 +15
==========================================
- Hits 16914 16832 -82
- Misses 4707 4779 +72
- Partials 642 653 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Didn't touch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with Donovan any concerns I had, looks good to go.
All Submissions:
New Feature Submissions:
Changes to Core Features:
How do you test these changes?
Removed commented code, test/core files, and test/performance files
Closes #310