Skip to content

430 configurable config file via build flags #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

Donnie-Ice
Copy link
Collaborator

@Donnie-Ice Donnie-Ice commented Mar 20, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

How do you test these changes?

Modify build script with -DFOO_BAR=XX and then print out the define in a unit test. Comment if you think any of the others should be converted to build flags.

API Changes:

N/A

@Donnie-Ice Donnie-Ice self-assigned this Mar 20, 2025
@Donnie-Ice Donnie-Ice linked an issue Mar 20, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.72%. Comparing base (14ee573) to head (01f8eb1).
Report is 99 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #433      +/-   ##
==========================================
- Coverage   75.97%   75.72%   -0.25%     
==========================================
  Files          81       81              
  Lines       22263    22742     +479     
  Branches     1807     1853      +46     
==========================================
+ Hits        16914    17222     +308     
- Misses       4707     4845     +138     
- Partials      642      675      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@dccutrig dccutrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed these as Donnie wrote them and we agreed on them. Some external thoughts would be nice to see if we arrive at the same conclusions.

@Donnie-Ice Donnie-Ice merged commit 6d206ea into dev Mar 25, 2025
12 checks passed
@Donnie-Ice Donnie-Ice deleted the 430-configurable-config-file-via-build-flags branch March 25, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable config file via build flags
4 participants