Skip to content

402 quickfix kmc should not call get key #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 25, 2025

Conversation

Donnie-Ice
Copy link
Collaborator

@Donnie-Ice Donnie-Ice commented Mar 25, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

How do you test these changes?

This contains all changes required so far to get kmc working. Can't really test.

@Donnie-Ice Donnie-Ice linked an issue Mar 25, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 52.15686% with 122 lines in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (14ee573) to head (2a938a0).
Report is 122 commits behind head on dev.

Files with missing lines Patch % Lines
src/core/crypto_tc.c 22.97% 33 Missing and 24 partials ⚠️
src/core/crypto_aos.c 37.14% 13 Missing and 9 partials ⚠️
src/core/crypto_tm.c 41.66% 10 Missing and 4 partials ⚠️
test/unit/ut_ep_sa_mgmt.c 66.66% 9 Missing ⚠️
test/unit/ut_ep_key_mgmt.c 77.77% 8 Missing ⚠️
src/core/crypto_config.c 25.00% 5 Missing and 1 partial ⚠️
test/unit/ut_ep_mc.c 66.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #440      +/-   ##
==========================================
- Coverage   75.97%   75.79%   -0.19%     
==========================================
  Files          81       80       -1     
  Lines       22263    22812     +549     
  Branches     1807     1845      +38     
==========================================
+ Hits        16914    17290     +376     
- Misses       4707     4850     +143     
- Partials      642      672      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Donnie-Ice Donnie-Ice merged commit 04373f7 into dev Mar 25, 2025
12 checks passed
@jlucas9 jlucas9 deleted the 402-quickfix-kmc-should-not-call-get_key branch April 1, 2025 12:33
@Donnie-Ice Donnie-Ice restored the 402-quickfix-kmc-should-not-call-get_key branch April 2, 2025 16:06
@Donnie-Ice Donnie-Ice deleted the 402-quickfix-kmc-should-not-call-get_key branch April 3, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quickfix: KMC should not call get_key
4 participants