Skip to content

[nasa/cryptolib#449] remove KMC_CFFI_EXCLUDE #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

Donnie-Ice
Copy link
Collaborator

@Donnie-Ice Donnie-Ice commented Apr 3, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

How do you test these changes?

Hayk specifically requested this, so we should be good to merge it

@Donnie-Ice Donnie-Ice self-assigned this Apr 3, 2025
@Donnie-Ice Donnie-Ice linked an issue Apr 3, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.99%. Comparing base (c42bed7) to head (dbad95d).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #450   +/-   ##
=======================================
  Coverage   74.99%   74.99%           
=======================================
  Files          80       80           
  Lines       23341    23341           
  Branches     1872     1872           
=======================================
  Hits        17505    17505           
  Misses       5168     5168           
  Partials      668      668           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Donnie-Ice Donnie-Ice merged commit d72b9e2 into dev Apr 3, 2025
12 checks passed
@Donnie-Ice Donnie-Ice deleted the 449-remove-kmc_cffi_exclude-and-uses branch April 3, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove KMC_CFFI_EXCLUDE and uses
4 participants