Skip to content

451 switch sa interface to be more like an api #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 23, 2025

Conversation

Donnie-Ice
Copy link
Collaborator

@Donnie-Ice Donnie-Ice commented Apr 7, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

How do you test these changes?

Exploring this as a possible improvement. Is this functionality needed/wanted?

@Donnie-Ice Donnie-Ice added the enhancement New feature or request label Apr 7, 2025
@Donnie-Ice Donnie-Ice self-assigned this Apr 7, 2025
@Donnie-Ice Donnie-Ice linked an issue Apr 7, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 67.34694% with 16 lines in your changes missing coverage. Please review.

Project coverage is 82.24%. Comparing base (14ee573) to head (91dd7c2).
Report is 236 commits behind head on dev.

Files with missing lines Patch % Lines
src/sa/internal/sa_interface_inmemory.template.c 68.42% 10 Missing and 2 partials ⚠️
src/core/crypto_tc.c 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #452      +/-   ##
==========================================
+ Coverage   75.97%   82.24%   +6.26%     
==========================================
  Files          81       39      -42     
  Lines       22263    11950   -10313     
  Branches     1807      978     -829     
==========================================
- Hits        16914     9828    -7086     
+ Misses       4707     1746    -2961     
+ Partials      642      376     -266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Donnie-Ice Donnie-Ice merged commit be6bac8 into dev Jun 23, 2025
12 checks passed
@Donnie-Ice Donnie-Ice deleted the 451-switch-sa-interface-to-be-more-like-an-api branch June 23, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Switch SA interface to be more like an API
4 participants