Skip to content

WIP [nasa/cryptolib#385] Operational sas for testing in nos3 #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 2, 2025

Conversation

jlucas9
Copy link
Collaborator

@jlucas9 jlucas9 commented Apr 30, 2025

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.82716% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.25%. Comparing base (14ee573) to head (936c85d).
Report is 234 commits behind head on dev.

Files with missing lines Patch % Lines
src/core/crypto_config.c 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #460      +/-   ##
==========================================
+ Coverage   75.97%   82.25%   +6.28%     
==========================================
  Files          81       39      -42     
  Lines       22263    11944   -10319     
  Branches     1807      969     -838     
==========================================
- Hits        16914     9825    -7089     
+ Misses       4707     1754    -2953     
+ Partials      642      365     -277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Donnie-Ice Donnie-Ice requested review from Donnie-Ice and dccutrig July 2, 2025 15:41
Copy link
Contributor

@dccutrig dccutrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@Donnie-Ice
Copy link
Collaborator

This will require A LOT of unit test work. May be more worthwhile to massage the SAs in dev to work on nos3 than to use the nos3 SAs on dev

@Donnie-Ice Donnie-Ice merged commit 952a1e9 into dev Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operational SAs for Testing in NOS3
4 participants