Skip to content

463 resolve memory leaks in uts #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jun 23, 2025
Merged

Conversation

Donnie-Ice
Copy link
Collaborator

@Donnie-Ice Donnie-Ice commented May 6, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

How do you test these changes?

Resolves all memory leaks in UTs. Currently has -fsanitize=address set in the CMakeLists file, so you should be able to just run the UTs and see if any fail. FHECF is also commented out in this as it repeatedly stomps on itself while calculating.

@Donnie-Ice Donnie-Ice linked an issue May 6, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2025

Codecov Report

Attention: Patch coverage is 95.70552% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.00%. Comparing base (14ee573) to head (478c31f).
Report is 244 commits behind head on dev.

Files with missing lines Patch % Lines
src/core/crypto_tc.c 69.23% 3 Missing and 1 partial ⚠️
src/core/crypto_aos.c 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #464      +/-   ##
==========================================
+ Coverage   75.97%   82.00%   +6.02%     
==========================================
  Files          81       39      -42     
  Lines       22263    11945   -10318     
  Branches     1807      973     -834     
==========================================
- Hits        16914     9795    -7119     
+ Misses       4707     1778    -2929     
+ Partials      642      372     -270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Donnie-Ice Donnie-Ice requested review from jlucas9 and dccutrig May 9, 2025 17:17
@Donnie-Ice Donnie-Ice requested a review from rjbrown2 June 16, 2025 19:08
@Donnie-Ice Donnie-Ice merged commit 187358b into dev Jun 23, 2025
12 checks passed
@Donnie-Ice Donnie-Ice deleted the 463-resolve-memory-leaks-in-uts branch June 23, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Resolve memory leaks in UTs
4 participants