Skip to content

[nasa/nos3#688] Updates from Donnie-Ice for NOS3 vcid 3 fix; #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 29, 2025

Conversation

jlucas9
Copy link
Collaborator

@jlucas9 jlucas9 commented Jul 23, 2025

Resolved VCID 3 issue when running in NOS3's CryptoLib GSW / Standalone that caused an error when calling TC Apply Security.

@jlucas9 jlucas9 self-assigned this Jul 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.93%. Comparing base (478c31f) to head (86d5382).
Report is 77 commits behind head on dev.

Files with missing lines Patch % Lines
src/core/crypto_config.c 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #479      +/-   ##
==========================================
- Coverage   82.00%   81.93%   -0.07%     
==========================================
  Files          39       39              
  Lines       11945    12103     +158     
  Branches      973      979       +6     
==========================================
+ Hits         9795     9917     +122     
- Misses       1778     1815      +37     
+ Partials      372      371       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlucas9
Copy link
Collaborator Author

jlucas9 commented Jul 24, 2025

Prior to merge need to also update the Readme file to change to point to Justin R. Morris

@jlucas9 jlucas9 merged commit 5029af5 into dev Jul 29, 2025
13 checks passed
@jlucas9 jlucas9 deleted the nos3#688-rc-1.7.3 branch July 29, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants