Skip to content

[nasa/nos3#755] add initial aos functionality #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Donnie-Ice
Copy link
Contributor

@Donnie-Ice Donnie-Ice commented Jul 25, 2025

Adds AOS functionality as a build option in toolchain-amd64-nos3.cmake.

To test:

  • Update line to set(TO_TRANSPORT aos_tf) in cfg/nos3_defs/toolchain-amd64-nos3.cmake
  • make && make launch
  • Run Mission_Test in Test Runner.

Requires:

Notes:

  • This was very quickly thrown together, so may be many missed pieces
  • CryptoLib standalone is currently dealing with these packets in a very "hackish" way

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.23%. Comparing base (1a44190) to head (81b33d5).
⚠️ Report is 6 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #767      +/-   ##
==========================================
- Coverage   73.65%   73.23%   -0.42%     
==========================================
  Files         761      764       +3     
  Lines       93963    94501     +538     
  Branches     7064     7151      +87     
==========================================
  Hits        69210    69210              
- Misses      24753    25291     +538     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified per instructions.

@Will-Matheny Will-Matheny self-requested a review August 5, 2025 15:27
Copy link

@Will-Matheny Will-Matheny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through instructions on shared folders and without; Everything worked. (on older JSTAR laptop)

@Isgaroth-the-Green
Copy link
Contributor

I am getting one error running on shared folders:
image

@Donnie-Ice
Copy link
Contributor Author

@Isgaroth-the-Green I've gotten this error for months. @kevincbruce also mentioned it in RC 1.7.3:

the debug test in Mission_Test is broken. It says that the get_debug_sc_hk() command doesn't exist. Not sure if this is outdated or just broken, but should be fixed or removed at some point.

I'm not sure if this is just outdated or broken.

Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, everything else appears to work, so approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants