Upgrade async gem fix specs 5.0 #236
Conversation
Rakefile
Outdated
| @@ -47,10 +49,13 @@ end.spec 'neo4j-ruby-driver' do | |||
| spec_extras[:requirements] = ->(requirements) { requirements << 'jar org.neo4j.driver, neo4j-java-driver-all, 5.27.0' } | |||
| spec_extras[:platform] = 'java' | |||
| else | |||
| dependency 'async', '< 2.13' | |||
| dependency 'async', '>= 0' | |||
There was a problem hiding this comment.
do your changes work with async < 2.13?
There was a problem hiding this comment.
Probably not. I will adjust PR.
|
@petergebala sorry for the delayed response.
It is not so much a goal to eliminate the cluster tests as it is a pain to maintain them. They are quite brittle and do not work on driver 5.0 at all.
Yes, keep all tests that run against a single neo4j instance or no instance at all.
Not the only source but having them all pass would be fantastic.
testkit on github actions runs in docker container. Some of the testkit tests run against a stubbed server, which can easily simulate different scenarios that would be hard to do on a real server.
|
|
I pushed changes. I was also able to run testkit locally and replicate failing tests. I will work on them in free time. |
|
@petergebala could you refresh your branch with the current 5.0. We will try to merge your PR as the failing testkit is not related. |
Hi @klobuczek
As you mentioned in #235
Here you have code changes against the
5.0branch.About cluster tests and Testkit.
If I understand correctly, the ultimate goal is to eliminate cluster integration tests, that are setup with
neoctrl-*.What about other Ruby specs in the main project? Do you want to keep them? Is Testkit gonna be the only source of truth?
I haven't run Testkit yet in the docker container. I am not sure what is your point of view of having dockerized version.
Waiting for your comments :)