Skip to content

Update the data serialization in hl_api_server.py #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 13, 2025
Merged

Update the data serialization in hl_api_server.py #3488

merged 5 commits into from
Aug 13, 2025

Conversation

vvorobjov
Copy link
Contributor

@vvorobjov vvorobjov commented Apr 25, 2025 •
edited
Loading

int64 cannot be serialized by default jsonify,

this change adds the serialization of all int* types to serialize_data function and uses it before sending the server response

fixes #3487

@vvorobjov vvorobjov mentioned this pull request Apr 25, 2025
Closed
med-ayssar
med-ayssar reviewed Apr 26, 2025
View reviewed changes
vvorobjov and others added 2 commits April 28, 2025 12:32
@vvorobjov @med-ayssar
Update pynest/nest/lib/hl_api_types.py
2f3bb67 
Co-authored-by: med-ayssar <med.ayssar@gmail.com>
@vvorobjov
Fix the code
c536db0
@vvorobjov vvorobjov requested a review from med-ayssar May 5, 2025 09:19
@babsey babsey requested review from babsey and removed request for med-ayssar May 6, 2025 11:09
@gtrensch gtrensch added T: Bug Wrong statements in the code or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 2, 2025
@gtrensch gtrensch moved this from To do to Review in Installation Jun 2, 2025
@heplesser heplesser added S: High Should be handled next and removed S: Normal Handle this with default priority labels Jun 30, 2025
@heplesser
Copy link
Contributor

@babsey Ping for review!

babsey
babsey suggested changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@babsey babsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I would suggest a code at line 264 in pynest/nest/server/hl_api_server.py:
response = [nest.serialize_data(master_response)]

@vvorobjov
Update hl_api_server.py
edd0a3f 
The proposed changes by @babsey
@vvorobjov
Copy link
Contributor Author

@babsey the proposed changes are added

@vvorobjov vvorobjov requested review from med-ayssar and babsey July 18, 2025 09:27
@terhorstd terhorstd requested review from gtrensch and removed request for med-ayssar July 28, 2025 10:01
babsey
babsey approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@babsey babsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heplesser heplesser requested review from med-ayssar and removed request for gtrensch August 7, 2025 13:41
med-ayssar
med-ayssar approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@med-ayssar med-ayssar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@terhorstd terhorstd merged commit 56f6f70 into nest:master Aug 13, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Installation Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@babsey babsey babsey approved these changes

@med-ayssar med-ayssar med-ayssar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Installation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serialization error when working with nest-server-mpi
6 participants
@vvorobjov @heplesser @babsey @med-ayssar @terhorstd @gtrensch