Skip to content

WIP: Fix warning nf corelint #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 35 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
c1aae68
no need to skip these
maxulysse Aug 14, 2025
8746d12
remove TODO
maxulysse Aug 14, 2025
594607a
add description and mimetype
maxulysse Aug 14, 2025
09b3b90
update CHANGELOG
maxulysse Aug 14, 2025
a05fb20
Merge branch 'dev' into fix_warning_nf-corelint
maxulysse Aug 14, 2025
cf0570e
should fix some warnings for subworkflows
maxulysse Aug 14, 2025
a618e2a
update all modules and subworkflows
maxulysse Aug 14, 2025
cdbecec
update snapshots
maxulysse Aug 14, 2025
a83e3cd
update CHANGELOG
maxulysse Aug 14, 2025
fb57dd6
fix modules usage
maxulysse Aug 14, 2025
a6ab063
fix APPLYBQSR
maxulysse Aug 14, 2025
849f587
fix freebayes versions
maxulysse Aug 14, 2025
316ca9a
fix cnvkit versions in snapshots
maxulysse Aug 14, 2025
c610992
fix applybqsr outputs
maxulysse Aug 14, 2025
a0d4e0b
update more snapshots
maxulysse Aug 14, 2025
d5f1b71
update cnvkit
maxulysse Aug 14, 2025
f073996
update cnvkit tests
maxulysse Aug 15, 2025
5fb62eb
update gatk4spark/applybqsr
maxulysse Aug 15, 2025
f41c2ed
fix failure and snapshot
maxulysse Aug 15, 2025
d27972d
update deepvariant
maxulysse Aug 15, 2025
81a9a2c
update more modules
maxulysse Aug 18, 2025
0454fa1
update snapshots
maxulysse Aug 18, 2025
c535870
--tools null -> --tools false
maxulysse Aug 18, 2025
67ccdee
Update tests/preprocessing_umi.nf.test.snap
maxulysse Aug 18, 2025
a867aba
update all gatk4 modules
maxulysse Aug 18, 2025
397e36a
fix applybqsr
maxulysse Aug 18, 2025
55fccfb
fix applybqsr
maxulysse Aug 19, 2025
bb90b97
update snapshots
maxulysse Aug 19, 2025
2c2479f
pre-commit tests
maxulysse Aug 19, 2025
1ca7d64
no need for tests
maxulysse Aug 19, 2025
29190e2
Merge branch 'dev' into fix_warning_nf-corelint
maxulysse Aug 19, 2025
6f55124
fix MERGE_BQSR usage
maxulysse Aug 19, 2025
332e9b1
update snapshots
maxulysse Aug 19, 2025
0251bed
update all gatk4*/applybqsr
maxulysse Aug 19, 2025
7b36a21
Merge branch 'dev' into fix_warning_nf-corelint
maxulysse Aug 19, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .nf-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@ lint:
files_exist:
- .github/workflows/awsfulltest.yml
- .github/workflows/awstest.yml
- .github/workflows/ci.yml
- conf/modules.config
files_unchanged:
- .gitignore
- assets/nf-core-sarek_logo_light.png
- docs/images/nf-core-sarek_logo_dark.png
- docs/images/nf-core-sarek_logo_light.png
Expand Down
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
| -------------------------------------- | ----------- | ----------- |
| `ASCAT` | 3.1.1 | 3.2.0 |
| `bcftools` | 1.20 | 1.21 |
| `cnvkit` | 0.9.10 | 0.9.12 |
| `deepvariant` | 1.8.0 | 1.9.0 |
| `ensemblvep` | 113.0 | 113.4 |
| `fastp` | 0.23.4 | 0.24.0 |
| `fgbio` | 2.2.1 | 2.4.0 |
| `fgbio` | 2.2.1 | 2.5.21 |
| `freebayes` | 1.3.6 | 1.3.10 |
| `gatk4` | 4.5.0.0 | 4.6.1.0 |
| `mosdepth` | 0.3.8 | 0.3.10 |
| `msisensor-pro` | 1.2.0 | 1.3.0 |
| `MuSE` | | 2.1.2 |
| `MultiQC` | 1.25.1 | 1.30 |
| `samtools` (in `BWAMEM1_MEM`) | 1.2 | 1.21 |
Expand Down Expand Up @@ -117,6 +121,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1932](https://github.com/nf-core/sarek/pull/1932) - Refactor and simplify pipeline test suite
- [1936](https://github.com/nf-core/sarek/pull/1936) - Template update for nf-core/tools v3.3.2
- [1954](https://github.com/nf-core/sarek/pull/1954) - Refactor bcftools annotation subworkflows so that no diff is necessary from nf-core/modules
- [1955](https://github.com/nf-core/sarek/pull/1955) - Update all modules and subworkflows

#### Fixed

Expand All @@ -135,6 +140,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1932](https://github.com/nf-core/sarek/pull/1932) - Fix typo for in UMI warning message
- [1933](https://github.com/nf-core/sarek/pull/1933) - Correct link in README
- [1935](https://github.com/nf-core/sarek/pull/1935) - Fix bug in samplesheet_to_channel workflow due to bad integer handling with lane
- [1955](https://github.com/nf-core/sarek/pull/1955) - Fix nf-core/tools lint Pipeline Test Warnings
- [1955](https://github.com/nf-core/sarek/pull/1955) - Fix nf-core/tools lint Subworkflow Test Warnings

#### Removed

Expand Down
2 changes: 0 additions & 2 deletions conf/base.config
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
*/

process {

// TODO nf-core: Check the defaults for all processes
cpus = { 1 * task.attempt }
memory = { 6.GB * task.attempt }
time = { 8.h * task.attempt }
Expand Down
6 changes: 5 additions & 1 deletion conf/modules/recalibrate.config
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ process {
if (params.use_gatk_spark) {
containerOptions = ''
}
ext.prefix = { meta.num_intervals <= 1 ? "${meta.id}.recal" : "${meta.id}_${intervals.baseName}.recal" }
ext.prefix = {
meta.num_intervals <= 1 ?
"${meta.id}.recal." + (params.save_output_as_bam ? 'bam' : 'cram') :
"${meta.id}_${intervals.baseName}.recal." + (params.save_output_as_bam ? 'bam' : 'cram')
}
publishDir = [
mode: params.publish_dir_mode,
path: { "${params.outdir}/preprocessing/" },
Expand Down
216 changes: 108 additions & 108 deletions modules.json

Large diffs are not rendered by default.

114 changes: 67 additions & 47 deletions modules/nf-core/ascat/meta.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 13 additions & 11 deletions modules/nf-core/bcftools/concat/meta.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 25 additions & 16 deletions modules/nf-core/bcftools/mpileup/meta.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading