-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Revise the primary product overview pages #1475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Revise the primary product overview pages #1475
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1755fa2
to
371aece
Compare
54a928c
to
4fa67d9
Compare
1be9756
to
5cda8ba
Compare
e78c3eb
to
72b3d24
Compare
0d6783f
to
d9aac91
Compare
3a1cda2
to
7291853
Compare
@S3Prototype you can disregard my review request for the moment, going to heavily revise this page after getting feedback from Niji and probably repurpose a lot of this content on the "interior" overview pages. |
docs/universal-gateway/overview.mdx
Outdated
|
||
Dive into the different parts of the Universal Gateway like Endpoints, Bindings, Pools, and Domains to understand how they work. | ||
## Universal Gateway features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you feel about dropping "Universal Gateway" in these headings? So just "Features" and "Use cases"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a thought that it might help with SEO but I don't actually know if that's true. 🤷♂️ I don't have a strong opinion either way but your suggestion is definitely cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samcrichard and @jnbritton might have input in regard to SEO
- [TCP Addresses →](/universal-gateway/tcp-addresses/) | ||
- [TLS Certificates →](/universal-gateway/tls-certificates/) | ||
- [Edges →](/universal-gateway/edges/) | ||
- [**Traffic Policy**](/docs/traffic-policy/): filter, match, manage, and orchestrate traffic to your endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ended up wrapped in the definition component, which is kind of interesting. I can update the code to not do that. How do you feel about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally don't know if it's a good or bad thing that's why I'm asking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I kind of like it? It's the only proper noun / ngrokism on the list and I like that the definition component kind of underscores that and offers some reassurance that you're not expected to know what it is already.
|
||
[Endpoints](/universal-gateway/endpoints/) are how ngrok enables traffic to reach your services. | ||
Here are some of the most common use cases for the Universal Gateway, from the [examples collection](/universal-gateway/examples/): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love these 👍
expanding the scope of this PR to include the other primary product overview pages. |
050e397
to
fbb4da4
Compare
1f86b15
to
2b1d241
Compare
bringing a clear purpose and standardized structure to the primary entry points into ngrok's key features: