-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Create traffic-policy-unit-pricing #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adding page for TPU for new pricing
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is awesome. Just a couple comments to clear up
## Actions, Expressions, and Variables | ||
|
||
- [**Actions**](https://ngrok.com/docs/traffic-policy/concepts/actions/): Define what happens when a traffic policy rule matches (e.g. add headers, deny a request, forward traffic). | ||
- [**Expressions**](https://ngrok.com/docs/traffic-policy/concepts/expressions/): Conditions (written in CEL) that determine whether actions execute, based on request or connection properties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be Expressions? Or maybe we need to add Macros to this section somewhere? Just at a glance, I wouldn't expect Macros to have its own dedicated section, but not be listed here, while Expressions doesn't have its own section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be Macros
, the description is correctly about Expressions, but I don't see Expression pricing below, instead I see Variable and Macro pricing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick copyediting review here!
Co-authored-by: Shaquil Hansford <liuqahs15@gmail.com>
Co-authored-by: SG <212444234+sg-writer@users.noreply.github.com>
Co-authored-by: SG <212444234+sg-writer@users.noreply.github.com>
Co-authored-by: SG <212444234+sg-writer@users.noreply.github.com>
Co-authored-by: SG <212444234+sg-writer@users.noreply.github.com>
Co-authored-by: SG <212444234+sg-writer@users.noreply.github.com>
Adding page for TPU for new pricing.
Needs to show what we charge for each TPU, how we calculate, and what discounted pricing at scale looks like.