Skip to content

Conversation

samcrichard
Copy link
Collaborator

Adding page for TPU for new pricing.

Needs to show what we charge for each TPU, how we calculate, and what discounted pricing at scale looks like.

Adding page for TPU for new pricing
Copy link

vercel bot commented Aug 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
ngrok-docs Ready Ready Preview Aug 22, 2025 5:19pm

Copy link
Collaborator

@S3Prototype S3Prototype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is awesome. Just a couple comments to clear up

## Actions, Expressions, and Variables

- [**Actions**](https://ngrok.com/docs/traffic-policy/concepts/actions/): Define what happens when a traffic policy rule matches (e.g. add headers, deny a request, forward traffic).
- [**Expressions**](https://ngrok.com/docs/traffic-policy/concepts/expressions/): Conditions (written in CEL) that determine whether actions execute, based on request or connection properties.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Expressions? Or maybe we need to add Macros to this section somewhere? Just at a glance, I wouldn't expect Macros to have its own dedicated section, but not be listed here, while Expressions doesn't have its own section

Copy link
Collaborator

@nijikokun nijikokun Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be Macros, the description is correctly about Expressions, but I don't see Expression pricing below, instead I see Variable and Macro pricing.

Copy link
Contributor

@sg-writer sg-writer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick copyediting review here!

@sg-writer sg-writer added docs/content Changes to the written material in the docs area/traffic-policy labels Aug 20, 2025
samcrichard and others added 5 commits August 21, 2025 17:00
Co-authored-by: Shaquil Hansford <liuqahs15@gmail.com>
Co-authored-by: SG <212444234+sg-writer@users.noreply.github.com>
Co-authored-by: SG <212444234+sg-writer@users.noreply.github.com>
Co-authored-by: SG <212444234+sg-writer@users.noreply.github.com>
samcrichard and others added 2 commits August 22, 2025 13:04
Co-authored-by: SG <212444234+sg-writer@users.noreply.github.com>
Co-authored-by: SG <212444234+sg-writer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/traffic-policy docs/content Changes to the written material in the docs kind/new-doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants