feat: Fallback to nixpkgs#nixos-facter
if not available in booted system
#569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback to
nixos-facter
fromnixpkgs
if not available in the booted system.This way we can skip the specific image requirement, while still
supporting the specific
nixos-facter
in a booted image, ifavailable
.Can improve bootstrapping of
nixos-anywhere
.Alternatives:
nixos-facter
fromnixpkgs
we could theoretically get an uncached version and would need to
build. We could test for that with
--max-jobs 0
and give anapproriate error message.
Tested:
nixosTest
for the functionality.