nixos-anywhere: fix running nixos-facter when it isn't installed
#575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this locally and it works 👍 |
sedlund
reviewed
Jul 31, 2025
a-kenji
requested changes
Jul 31, 2025
There was a problem hiding this comment.
I tested the PR and it now fails when nixos-facter is not installed as opposed to before.
This is the error I get:
error: unable to execute 'sudo': No such file or directory
On main this works. I suspect it is because of: abfb275
The quoting is now correct so that is approved. Unsure if the first revert is really necessary seeing as you completely rewrote everything there anyway.
|
How are you testing it? |
|
This is how I tested it: |
|
Ah, I found the issue. Edit: #576 |
…acter` call" This reverts commit 29f6973.
…ter` call" This reverts commit abfb275.
This is unnecessary because we switch to using `root` after we kexec and `nixos-images` provides an installer without `sudo` so this actively causes installations to fail if a user wasn't already booted into a NixOS installer.
Enzime
force-pushed
the
push-krzlkykyknrl
branch
from
e25d677 to
d239ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #570 as I think we still want to run
nixos-facterwithsudoif possible and the changing the order of the flags doesn't fix the quoting issues