Converting the AWS SES integration from SMTP to direct SES client usage #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianStehle
requested changes
May 28, 2025
| catch (Exception ex) | ||
| { | ||
| var error = string.Format(CultureInfo.InvariantCulture, Texts.SMTP_Exception, ex.Message); | ||
| throw new DomainException(error, ex); |
There was a problem hiding this comment.
Domain exception are potentially shown to the user. I am not surre if you always want to do that.
| { | ||
| var r = Convert(context, request); | ||
| var response = await amazonSES.SendRawEmailAsync(r, ct); | ||
| if (response.HttpStatusCode != System.Net.HttpStatusCode.OK) |
There was a problem hiding this comment.
Please import namespaces if there are not conflicts.
| FillContext(context); | ||
| try | ||
| { | ||
| var r = Convert(context, request); |
There was a problem hiding this comment.
Please no appreviations like "r"...call it "rawRequest"?
|
|
||
| smtpMessage.Subject = request.Subject; | ||
|
|
||
| using (var messageStream = new MemoryStream()) |
There was a problem hiding this comment.
Can this be implemented without the memory stream, e.g. by writing to the request directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing SES integration reuses the SMTP integration, thus requiring an SMTP endpoint and extra credentials for deployment. Switching to direct SES client usage removes that dependency.