aws sg analysis #648
aws sg analysis #648
Conversation
pkg/awsvpc/examples/out/analysis_out/config_object_all_vpcs_.txt
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
can you capture common functionality of both parsers to common package? check duplicated code such as printing functions, code that handles the objects of the common types, etc.
|
|
||
| /********** Functions used in Debug mode ***************/ | ||
|
|
||
| func printVPCConfigs(c *vpcmodel.MultipleVPCConfigs) { |
There was a problem hiding this comment.
why can't all the printing functions be in commonvpc?
There was a problem hiding this comment.
because it calls printConfigs func which is specific for each provider(for now)
There was a problem hiding this comment.
can't this function be common for all providers? it iterates over objects from vpcmodel pkg
There was a problem hiding this comment.
can't, because for ex in ibmvpc this function calls printTGWAvailableRoutes which is specific for ibm and includes struct type that is in ibmvpc pkg.. if the struct were defined in commonvpc (it is not used in aws..) it will be possible to move the func to common-code
I can split the func to two functions.. but I think it is better leave it this way..
There was a problem hiding this comment.
ok, let's consider this for a followup PR
There was a problem hiding this comment.
Better have it in this PR. For one, I find it hard to understand the code without documentation.
|
LGTM |
pkg/awsvpc/sg_analysis.go
Outdated
| case commonvpc.ProtocolTCP: | ||
| ruleStr, ruleRes, err = sga.getProtocolTCPUDPRule(&ruleObj, direction) | ||
| case commonvpc.ProtocolUDP: | ||
| ruleStr, ruleRes, err = sga.getProtocolTCPUDPRule(&ruleObj, direction) |
There was a problem hiding this comment.
| case commonvpc.ProtocolTCP: | |
| ruleStr, ruleRes, err = sga.getProtocolTCPUDPRule(&ruleObj, direction) | |
| case commonvpc.ProtocolUDP: | |
| ruleStr, ruleRes, err = sga.getProtocolTCPUDPRule(&ruleObj, direction) | |
| case commonvpc.ProtocolTCP, commonvpc.ProtocolUDP: | |
| ruleStr, ruleRes, err = sga.getProtocolTCPUDPRule(&ruleObj, direction) |
pkg/awsvpc/sg_analysis_test.go
Outdated
| VPCRef: nil, | ||
| Region: "", | ||
| }, | ||
| Analyzer: commonvpc.NewSGAnalyzer(NewAWSSGAnalyzer(&sg)), Members: nil, |
There was a problem hiding this comment.
vscode warning: unused write to field Members
pkg/awsvpc/sg_analysis_test.go
Outdated
| VPCRef: nil, | ||
| Region: "", | ||
| }, | ||
| Analyzer: commonvpc.NewSGAnalyzer(NewAWSSGAnalyzer(&sg)), Members: nil, |
There was a problem hiding this comment.
vscode warning: unused write to field Members
pkg/commonvpc/vpc.go
Outdated
| "github.com/np-guard/vpc-network-config-analyzer/pkg/vpcmodel" | ||
| ) | ||
|
|
||
| const DoubleTab = "\t\t" |
There was a problem hiding this comment.
this const is only used in ibmvpc
|
No description provided.