504 lint overlap subnets #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisos
reviewed
Jul 21, 2024
|
|
||
| "Overlapping CIDR ranges between different subnets" issues: | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| subnet subnet1-ky of cidr 10.240.10.0/16 and subnet subnet2-ky of cidr 10.240.20.0/24, both from VPC test-vpc1-ky, overlap in 10.240.20.0/24 |
There was a problem hiding this comment.
isn't the goal to warn about subnets from different VPCs with overlapping ranges?
I don't think it's possible to configure such subnets in the same VPC.
There was a problem hiding this comment.
Yes, you are correct. It should not be possible. Redundant code and test removed.
There was a problem hiding this comment.
please remove also the output file + add another relevant test instead
There was a problem hiding this comment.
right. output file removed. Added a test in which the overlapping is in part of the range (in which case the output is slightly different)
adisos
reviewed
Jul 21, 2024
adisos
reviewed
Jul 21, 2024
adisos
reviewed
Jul 21, 2024
adisos
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #116