-
Notifications
You must be signed in to change notification settings - Fork 10
[Dune] Add domain flag to ortac-dune qcheck-stm #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
n-osborne
wants to merge
14
commits into
ocaml-gospel:main
Choose a base branch
from
n-osborne:dune-rules-qcheck-stm-domain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Dune] Add domain flag to ortac-dune qcheck-stm #329
n-osborne
wants to merge
14
commits into
ocaml-gospel:main
from
n-osborne:dune-rules-qcheck-stm-domain
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a314d20
to
bcc3008
Compare
bcc3008
to
cefbf18
Compare
cefbf18
to
de76e23
Compare
In particular, this runtime ignores the report build by the generated `ortac_postcond` function and uses the initial `cmd_show`.
de76e23
to
605e9b7
Compare
Default is false and generates test in a sequential context.
This first version makes the following design choice: when testing in a concurrent context, we don't store the new SUTs created during the tests. This weakens the tests of the sequential prefix compared to the sequential tests. The rational is about ease of implementation, allowing for tesing with domains without having to differentiate between commands ran in the sequential prefix and those ran in one of the spawned domain.
In order to have `build_if` available.
605e9b7
to
e3409e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Ortac/Dune support the new
--domain
flag for Ortac/QCheck-STM.This PR is based on #316 and #328. Please consider only the five last commits.